Enable Python workflow with BytePairTokenizer and StartEndPacker#2628
Open
james77777778 wants to merge 5 commits intokeras-team:masterfrom
Open
Enable Python workflow with BytePairTokenizer and StartEndPacker#2628james77777778 wants to merge 5 commits intokeras-team:masterfrom
BytePairTokenizer and StartEndPacker#2628james77777778 wants to merge 5 commits intokeras-team:masterfrom
Conversation
…dPacker` to `StartEndPacker`.
github-actions
bot
requested review from
divyashreepathihalli and
sachinprasadhs
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility and usability of key preprocessing layers, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request significantly improves the BytePairTokenizer and StartEndPacker layers by enabling Python workflow functionality, alongside the existing TensorFlow-compatible workflow. The refactoring of call methods into _call_tf and _call_python for StartEndPacker and the integration of the tokenizers library for BytePairTokenizer are well-executed. The extensive test updates, including parameterization for _allow_python_workflow, demonstrate thoroughness. The removal of v2 specific files for these components indicates a successful consolidation. However, there is an inconsistency in how invalid merge rules are handled between the Python and TensorFlow paths in BytePairTokenizer.
Note: Security Review did not run due to the size of the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
On second thought, I think merging the Python workflow functionality into the original
BytePairTokenizerandStartEndPackerlayers will provide a more seamless UX. Users will benefit from a default Python workflow while maintaining a smooth experience when using these layers withintf.data.Extensive tests have been added for these core modules:
keras_hub/src/tokenizers/byte_tokenizer_test.pykeras_hub/src/layers/preprocessing/start_end_packer_test.pyThe diff is quite large due to updated tests. I found that all
BytePairTokenizertests were WRONG: BPE requires all elements inmergesto be present invocabulary.Our
tfandtf-textimplementation is more permissive than widely adopted libraries liketokenizers.Key updates for reviewers:
_allow_python_workflowtoPreprocessingLayerto indicate whether a layer supports Python workflowReference
Colab Notebook
https://colab.research.google.com/drive/1YDHUwdjwgO0BGuelYLTRNvVB1Ulc1K7X?usp=sharing
Checklist